Promote amd-staging to amd-mainline#586
Closed
vedithal-amd wants to merge 7 commits intoamd-mainlinefrom
Closed
Conversation
* Add cmake function to create standalone binary * Mention licenses used by dependencies in the LICENSE file * Add test cases for standalone binary by adding --call-binary option for pytest * Docker compose file to create standalone binary in standardized RHEL 8 environment * Add README instructions on how to create and test standalone binary * Move docker files from utils to docker folder; Add standalone binary testing instructions * Add CHANGELOG statement * Use different service names in docker compose files * Use volume mounting in docker files
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
* Improve kokkos trace is handling. * Fix formatting. * Syntax fix and adding comments.
* Create VERSION.sha file while creating standalone binary * Do not fail on VERSION.sha not found * Add git to docker container for testing
vedithal-amd
requested review from
a team,
coleramos425,
dgaliffiAMD,
feizheng10 and
koomie
as code owners
Contributor
Author
|
I will do fast forward merge, closing this |
abchoudh-amd
pushed a commit
to abchoudh-amd/rocprofiler-compute
that referenced
this pull request
Jul 29, 2025
* Adding list-metrics * cmake formatting (cmake-format) (ROCm#587) Co-authored-by: SrirakshaNag <104580803+SrirakshaNag@users.noreply.github.com> * source formatting (clang-format v11) (ROCm#586) Co-authored-by: SrirakshaNag <104580803+SrirakshaNag@users.noreply.github.com> * Fixing issues with validation tests * python formatting (black) (ROCm#588) Co-authored-by: SrirakshaNag <104580803+SrirakshaNag@users.noreply.github.com> * source formatting (clang-format v11) (ROCm#589) Co-authored-by: SrirakshaNag <104580803+SrirakshaNag@users.noreply.github.com> * cmake formatting (cmake-format) (ROCm#590) Co-authored-by: SrirakshaNag <104580803+SrirakshaNag@users.noreply.github.com> * Update conftest.py * Update validate.py * python formatting (black) (ROCm#591) Co-authored-by: SrirakshaNag <104580803+SrirakshaNag@users.noreply.github.com> * python formatting (black) (ROCm#592) Co-authored-by: SrirakshaNag <104580803+SrirakshaNag@users.noreply.github.com> * Checking if agent-id in validate.py * Fixing list metrics execute test * cmake formatting (cmake-format) (ROCm#593) Co-authored-by: SrirakshaNag <104580803+SrirakshaNag@users.noreply.github.com> * Fixing CI failure * cmake formatting (cmake-format) (ROCm#594) Co-authored-by: SrirakshaNag <104580803+SrirakshaNag@users.noreply.github.com> * Review Comments * Update source/bin/rocprofv3 Support -L shorthand for --list-metrics --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jonathan R. Madsen <jrmadsen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.